I've added some extra logging when deleting addresses (I couldn't spot where you added the logging)
to fix the flaw while paginating the search results, I've split the logic in a loop that collects the operations to run and one more to actually run the requests. I wanted to experiment a different way from the one you've indicated but I am happy to switch to the "always scan the first page + sleep(1.5)" approach if you see any shortcomings on my approach!
I've introduced a test to avoid manual tests my solutions. I'm hoping this will come useful to partially automate testing for the other project I'll be working on.
flevour
commented
9 years ago
Implements feedback from from https://github.com/closeio/closeio-api/pull/46#issuecomment-150830246
Some things to notice:
/cc @philfreo