closeio / closeio-node

An Unofficial Close.io API wrapper for Node.js.
19 stars 18 forks source link

Can't use on Heroku. Preinstall script fails. #8

Closed summerville closed 9 years ago

summerville commented 9 years ago

What's the reason for this setup?

"scripts": {
    "preinstall": "sudo npm i -g mocha",
    "test": "mocha"
  },

It causes Heroku to fails whenever you use this lib in another project:

npm ERR! Failed at the close.io@0.0.4 preinstall script 'sudo npm i -g mocha'.
npm ERR! This is most likely a problem with the close.io package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     sudo npm i -g mocha
npm ERR! You can get their info via:
npm ERR!     npm owner ls close.io
npm ERR! There is likely additional logging output above.
philfreo commented 9 years ago

just merged #6. does that fix?

summerville commented 9 years ago

Boom! That got it :)