Support comparator in uniqify

closeio / flask-common

Some commonly shared code for Flask, MongoEngine, and Python apps

26 stars 4 forks source link

Closed charliewolf closed 8 years ago

thomasst commented 8 years ago

Looks good, here's my feedback:

Rename key_comparator to key to be consisted with Python's sorted(key=lambda: ...) (also, the function is not technically comparing two items, it's simply extracting the keys that will be compared)
Add explanation and/or an example to the doc string.

charliewolf commented 8 years ago

@thomasst Updated

thomasst commented 8 years ago

Great, and sorry, forgot to mention to add a test case in tests/__init__.py under UtilsTestCase.test_uniqify. Then it should be good to go.

charliewolf commented 8 years ago

Roger that. See latest commit.