search

closeio / flask-common

Some commonly shared code for Flask, MongoEngine, and Python apps
26 stars 4 forks source link

Add all packages in setup.py #43

Closed mpessas closed 6 years ago

thomasst commented 6 years ago

What does this do? Why do we need this?

mpessas commented 6 years ago

It includes the subpackages flask_common.utils and flask_common.fields' in the built package. Without that, running pip install git+https://github.com/closeio/flask-common.git#egg=flask_common leaves those directories out of the package.

tsx commented 6 years ago

My guess is that we need this to be able to drop -e from requirements.txt in other repos that depend on this one. Is that correct @mpessas ?

mpessas commented 6 years ago

It is @tsx. However, without the change the setup.py file is not correct in the first place.