Support for Python 3 / latest MongoEngine

closeio / flask-mongorest

Restful API framework wrapped around MongoEngine

Other

523 stars 88 forks source link

Support for Python 3 / latest MongoEngine #99

Closed thomasst closed 7 years ago

thomasst commented 7 years ago

This is tested on:

Python 2.7 and our own MongoEngine fork
Python 3.5 and upstream MongoEngine

Note that I skipped two tests since upstream MongoEngine doesn't have certain features like SafeReferenceField.

thomasst commented 7 years ago

@closeio/engineering please review (app tests pass as well)

tsx commented 7 years ago

LGTM

Note that I skipped two tests since upstream MongoEngine doesn't have certain features like SafeReferenceField.

If we don't/can't push that upstream, maybe we could put those in a separate lib/repo like "mongoengine-addons" which will work with both our fork and upstream mongoengine and depend on that?

thomasst commented 7 years ago

If we don't/can't push that upstream, maybe we could put those in a separate lib/repo like "mongoengine-addons" which will work with both our fork and upstream mongoengine and depend on that?

We'll have to do some more work before we do that – right now our changes don't merge in cleanly into the upstream MongoEngine.