search

closeio / lead-clipper

Chrome extension to create new leads in Close.io based on information from websites
close.io
8 stars 3 forks source link

Fixed LinkedIn to work with New Layout #12

Closed eengoron closed 7 years ago

eengoron commented 7 years ago

Hey Phil and Company --

I fixed the lead clipper to work with the new LinkedIn Layout.

I also added a bunch of functionality:

1) I made "Smart Addresses" that will now work with Google's new geoencoder rules. Essentially, it checks to see if it's an american address, if it isn't it has special rules to make sure things are mapped correctly. I parse the address based on the number of commas that appear in the address field.

2) You can now add all of your websites listed to the lead contact. But if there is a website that is listed with the type (Company Website), it'll add that to the main lead URL.

3) I added support to parse twitter handles and skype handles, but I didn't activate the skype handles because of the bug I'm about to email engineering about. But, I left in the functionality for a later release.

4) Support for descriptions of all sizes because their new layout truncates descriptions weirdly.

That about covers it. Let me know what you think!

eengoron commented 7 years ago

I've made every change except for the var city = state = country = address_1 ="" because grunt won't let me build it like that due to a warning that it's leaking a variable. I forced it through, but it's probably not ideal.

anemitz commented 7 years ago

ah, yeah could be. i'm not JS certified.

anemitz commented 7 years ago

Does this work for sales navigator or just the new LI layout?

Is it backwards compatible with the old one (if still in use)?

eengoron commented 7 years ago

Just the new LI Layout for now.

Haven't touched sales navigator. But, the new layout thing was more complained about

And the old layout is only in use on IE, so it wouldn't matter. But, no it isn't backwards compatible. It's just completely updated.

eengoron commented 7 years ago

I'm going to open a new pull request with the changes you mentioned.