search

closeio / lintlizard

For a good clean code feeling no matter what!
MIT License
5 stars 2 forks source link

Add tests #146

Open neob91-close opened 1 year ago

neob91-close commented 1 year ago

We have no tests whatsoever for lintlizard, while it should be fairly easy to mock out subprocess and make assertions on what commands are executed (and potentially what output is generated by lintlizard).

vtclose commented 1 year ago

Half of the "test suite" of lintlizard is running it on itself in CI. I agree having some actual tests would be nice though. As well as testing failures.

neob91-close commented 1 year ago

Well, --fix or --changed aren't running in CI (to my knowledge), so it's possible to break them without noticing

neob91-close commented 1 year ago

It's only checking for non-zero exit codes, right? https://github.com/closeio/lintlizard/pull/147

vtclose commented 1 year ago

Yep that's true, it's only regular runs.