search

closeio / lintlizard

For a good clean code feeling no matter what!
MIT License
5 stars 2 forks source link

Introduce ruff #172

Open neob91-close opened 1 year ago

neob91-close commented 1 year ago

Ruff is a linter boasting extreme speed and near-parity with the flake8 ruleset.

While speed is important, I think its greatest benefit is the ability to automatically fix issues. Not sure whether it could replace flake8, but if it doesn't conflict with it or black, it would be a great addition IMO.

neob91-close commented 1 year ago

CC @nsaje @tsx

nsaje commented 1 year ago

I would love a flake8 autofix functionality, I am a bit concerned with the maturity of ruff though - seems like it's quite new and under very active development.

How about considering https://github.com/PyCQA/autoflake ?

AlecRosenbaum commented 1 year ago

TIL about ruff.

I'd be happy with anything that automatically fixes unused imports, though it seems like ruff is pretty widely used by rather mature projects. If it really is as fast as it claims, both its speed and ability to auto fix feels like a game changer.

vtclose commented 1 year ago

It does look very interesting. I'm gonna test it out.

vtclose commented 1 year ago

It does look very good indeed. It covers more or less everything we need from flake8 and it's instant. 0.5s without cache, 0.1s with cache on our main codebase. Ruff even covers like 90% of our isort, only being incompatible with a couple configuration options. I'm more than willing to give up the remainder for autofix + instant linting.

If we replace both isort and flake8 with ruff, the only other tools in our setup are black and mypy, and neither of those need the "--changed" functionality. And with just 3 tools, maintaining a separate umbrella package for linting tools is pretty much unnecessary, so we can get rid of lintlizard altogether.

Thoughts?

neob91-close commented 1 year ago

Well, if we replaced flake8 and isort with ruff, then perhaps lintlizard might seem like overkill a little bit, but I don't think we should get rid of it just yet: