Closed charliewolf closed 8 years ago
It's an optional dependency. If you're just interested in parsing plain text emails, you don't need to install it.
It should at least be documented. Getting an ImportError when deploying is not the greatest way to find out such things.
Where? The README already says:
quotequail has no mandatory dependencies, however using HTML methods require libxml.
Aha, I am stupid and didn't see that.
I still think adding it to setup.py is the right approach, but it's not a particularly strongly held opinion.
I just don't want to make it a mandatory dependency. Also, your tests should have caught it before deploying it.
Feel free to reopen if you have specific suggestions on how to make it clearer, keeping in mind that libxml should stay as an optional dependency
In order to parse html emails, lxml is required. This should be added to setup.py.