search

closeio / quotequail

a library that identifies quoted text in email messages
MIT License
58 stars 23 forks source link

lxml is required #9

Closed charliewolf closed 8 years ago

charliewolf commented 8 years ago

In order to parse html emails, lxml is required. This should be added to setup.py.

thomasst commented 8 years ago

It's an optional dependency. If you're just interested in parsing plain text emails, you don't need to install it.

charliewolf commented 8 years ago

It should at least be documented. Getting an ImportError when deploying is not the greatest way to find out such things.

thomasst commented 8 years ago

Where? The README already says:

quotequail has no mandatory dependencies, however using HTML methods require libxml.

charliewolf commented 8 years ago

Aha, I am stupid and didn't see that.

I still think adding it to setup.py is the right approach, but it's not a particularly strongly held opinion.

thomasst commented 8 years ago

I just don't want to make it a mandatory dependency. Also, your tests should have caught it before deploying it.

thomasst commented 8 years ago

Feel free to reopen if you have specific suggestions on how to make it clearer, keeping in mind that libxml should stay as an optional dependency