search

closeio / socketshark

A WebSocket message router based on Python/Redis/asyncio
MIT License
116 stars 11 forks source link

why is struglog dev optional dependency included in the setup.py? #160

Closed amolinaalvarez closed 6 months ago

amolinaalvarez commented 8 months ago

Hi, I would like to clarify why is structlog dev optional dependency included in the setup.py file as a part of install_requires?

install_requires = [
    'aiohttp',
    'aioredis',
    'click',
    'structlog[dev]',  <---
    'websockets',
]

Thank you in advanced.

AlecRosenbaum commented 8 months ago

Good question, it seems like it's been that way since it was introduced in 2017. It was probably an oversight or was related to how structlog existed at the time.

Seems like something we should remove.

Would you like to open a PR for it?

amolinaalvarez commented 7 months ago

@AlecRosenbaum https://github.com/closeio/socketshark/pull/165

Thank you.