Refactor Redis keys to avoid duplicate string literals

closeio / tasktiger

Python task queue using Redis

MIT License

1.41k stars 80 forks source link

Open vishesh10 opened 9 months ago

vishesh10 commented 9 months ago

Replaced string literals in the Redis keys to constants.

Resolves #255

vishesh10 commented 9 months ago

Thanks for the review. If tests are skipped then there are very few changes in the code.

neob91-close commented 9 months ago

Not a problem! Thanks for looking into this!

There are a lot of places that need changes. A couple of examples:

There's probably a couple dozen lines that need an update.

vishesh10 commented 9 months ago

@neob91-close, Reverted the test cases and added changes at the appropriate places. Thanks

vishesh10 commented 8 months ago

Hi @neob91-close , Done changes as per the suggestions. Thanks