closerdao / closer-ui

closer-ui.vercel.app
Other
1 stars 0 forks source link

Booking for event #118

Closed marektucek closed 1 year ago

marektucek commented 1 year ago

Event page:

Admin: Separate out event.fee & accomodation.fee

Booking flow:

Book event -> /bookings/create/dates?event=eventID booking/dates -> show events, if select date with event change to event booking Booking/questions: hide if user.diet, user.mattress is set bookings/summary - add event ticket costs booking/checkout If api.credits.count > 0 - show credit discount, add credits: Number to booking call checkout: up-sell checkbox to get subscription

marektucek commented 1 year ago

User story As an authenticated user, I want to be able to book for events directly from the events list.

https://www.figma.com/file/zr7ncUdHTsMEv5haySrGTZ/TDF-Design-System-2.0?node-id=423-1853&t=WlQxC8VA0M6wdhw7-4

Scenario 1: An authenticated user sees a list of events in /events. He browses, chooses one and clicks "get a ticket" button. He is redirected to a booking flow, but the dates are already pre-selected according to the event specs. He completes the flow and in the checkout the event ticket price is added to the total.

Scenario 2: an unauthenticated user arrives at the /events page. He is prompted to log in/subscribe before he can buy a ticket for that event.

Variations:

marektucek commented 1 year ago

have a discussion about the event ticket. So far it doesnt make much sense to me: 1) user books for full length, comes at the beginning, leaves at the end, everyone is happy. 2) user wants to come for half of the event. Nobody is happy. 3) user wants to come before the event. Nobody is happy. 4) user wants to stay after the event. Nobody is happy.

marektucek commented 1 year ago

final comments @valieff

marektucek commented 1 year ago

testing:

marektucek commented 1 year ago

Image

missing a confirmation message if the code was or wasnt accepted (design here the code apparently works, there is a discount in the checkout, but during putting it in I have no idea if it works or not

marektucek commented 1 year ago

Image

Im able to book for any date, date could be picked from calendar freely. It should be restricted to the event's date. Im booking for Dummy Event

marektucek commented 1 year ago

Unauthenticated user event booking - forces me to sign in to book, works fine. doesnt feel like tearing me out from the flow, which is good.

marektucek commented 1 year ago

Image

Image

Im shown as a member automatically after signing up even though the admin interface says im not a member.

marektucek commented 1 year ago

Image

card canceling - placeholder text in all card types.

marektucek commented 1 year ago

Image

double check if the refund calculation is correct.

marektucek commented 1 year ago

Image

Open card canceling - says it will refund me money even though I havent paid (not even completed) the booking.

valieff commented 1 year ago
  • also there should be the "Success / Something went wrong" confirmation text

Image

Im able to book for any date, date could be picked from calendar freely. It should be restricted to the event's date. Im booking for Dummy Event

Fixed

valieff commented 1 year ago

Image

Open card canceling - says it will refund me money even though I havent paid (not even completed) the booking.

Should work now

valieff commented 1 year ago

Image

double check if the refund calculation is correct.

Tests definitely need to be added for that, will try to do it during clean-up

valieff commented 1 year ago

Image

Image

Im shown as a member automatically after signing up even though the admin interface says im not a member.

We have some confusion with terms here. "Member" role is assigned by an admin after the user meets certain criteria. "Member" in navigation bar does not mean you have a "Member" role assigned to you. It is hardcoded at the moment.

valieff commented 1 year ago

final comments @valieff

Let's discuss the discount code form functionality at the next standup. We may want to simplify this form.

marektucek commented 1 year ago

https://github.com/closerdao/closer-ui/issues/118#issuecomment-1522087366

the date is restricted now, but once i choose a different date (in range <event start, event end>) it cannot be changed back. This is for both the start and end calendars.

marektucek commented 1 year ago

when I go to finish booking through an Open ticket, I land in /summary. If I hit the Back button, i get a flash of /aboutyou and immediately return to /summary. If I keep hitting the Back button a lot, Im able to go back to /dates

marektucek commented 1 year ago

Image

I have just paid for my Confirmed booking and this is shown. Especially the last line is a problem, that I can now pay for my stay when I just did

valieff commented 1 year ago

#118 (comment)

the date is restricted now, but once i choose a different date (in range <event start, event end>) it cannot be changed back. This is for both the start and end calendars.

Fixed in https://github.com/traditionaldreamfactory/traditionaldreamfactory.com/pull/50

On Safari it is not apparent the the dates outside the event dates are blocked (they are not greyed out), but they are. This is because we are using the browser default date picker. Probably we should switch to some good looking date picker React component which will have better styling out of the box.