When next year bookings exist, new bookings' night price for this year has to be above the total of staked tokens for next year

[juliencharrel]

You can see a failed transaction because of it here: https://explorer.celo.org/alfajores/tx/0x9418a91c0e3440b2d2e5a54305ffb9441bb801e87ffb8e2520d3e6d461f1c0af

[arturictus]

I will need more context to understand the issue.

Here is a sheet explaining the behaviour: https://docs.google.com/spreadsheets/d/1qT5YXRc591LKYsmS9Y_T_vlv8usf6KHCWzXeQQootLg/edit?usp=sharing

[juliencharrel]

I found at least this line I'm not sure, I think it should be the max and not the sum for all subsequent years https://github.com/closerdao/TDF-contracts/blob/627b320fe5df3274d717ce158ff083a516cc1b45/src/diamond/libraries/StakeLibV2.sol#L40

[arturictus]

@juliencharrel this store is the staked coins, not the bookings so the sum of all staked coins should be equal to the max of future year bookings.

I think the best way to verify the case that you think is buggy is to write a test to probe that is or is not working

[juliencharrel]

I cannot reproduce my bug with another wallet, any clue on how I could debug more that transaction?

[arturictus]

I cannot reproduce my bug with another wallet, any clue on how I could debug more that transaction?

You should write a test with the conditions that raised the issue

[juliencharrel]

Yeah I wrote a test but not failing either, idk how to reproduce my current wallet conditions

On Thu, Jan 5, 2023 at 15:52 Artur @.***> wrote:

I cannot reproduce my bug with another wallet, any clue on how I could debug more that transaction?

You should write a test with the conditions that raised the issue

— Reply to this email directly, view it on GitHub https://github.com/closerdao/TDF-contracts/issues/33#issuecomment-1372318723, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6AJ3FPWFNJVWAJOQMCOZDWQ3N3FANCNFSM6AAAAAATLOJ2HI . You are receiving this because you were mentioned.Message ID: @.***>

[arturictus]

Yeah I wrote a test but not failing either, idk how to reproduce my current wallet conditions … On Thu, Jan 5, 2023 at 15:52 Artur @.> wrote: I cannot reproduce my bug with another wallet, any clue on how I could debug more that transaction? You should write a test with the conditions that raised the issue — Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6AJ3FPWFNJVWAJOQMCOZDWQ3N3FANCNFSM6AAAAAATLOJ2HI . You are receiving this because you were mentioned.Message ID: @.>

You can fork the blockchain in your local environment, and from there you could try to investigate. It's not easy but maybe you can write a test that executes against this fork and slowly slowly extract all the information you need.

[juliencharrel]

thx!

On Fri, Jan 6, 2023 at 2:02 PM Artur @.***> wrote:

Yeah I wrote a test but not failing either, idk how to reproduce my current wallet conditions … <#m-1084773548723428251> On Thu, Jan 5, 2023 at 15:52 Artur @.> wrote: I cannot reproduce my bug with another wallet, any clue on how I could debug more that transaction? You should write a test with the conditions that raised the issue — Reply to this email directly, view it on GitHub <#33 (comment) https://github.com/closerdao/TDF-contracts/issues/33#issuecomment-1372318723>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6AJ3FPWFNJVWAJOQMCOZDWQ3N3FANCNFSM6AAAAAATLOJ2HI https://github.com/notifications/unsubscribe-auth/AA6AJ3FPWFNJVWAJOQMCOZDWQ3N3FANCNFSM6AAAAAATLOJ2HI . You are receiving this because you were mentioned.Message ID: @.>

You can fork the blockchain in your local environment, and from there you could try to investigate. It's not easy but maybe you can write a test that executes against this fork and slowly slowly extract all the information you need.

— Reply to this email directly, view it on GitHub https://github.com/closerdao/TDF-contracts/issues/33#issuecomment-1373592004, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6AJ3EBX5LAINBQMK27MH3WRAJVNANCNFSM6AAAAAATLOJ2HI . You are receiving this because you were mentioned.Message ID: @.***>

[arturictus]

@juliencharrel any progress here?

[arturictus]

I close it because of inactivity