search

closerdao / proof-of-presence

TDF smart contracts
MIT License
2 stars 3 forks source link

Investigate the usefulness of lastPrice (hint: it seems to be useless) #35

Closed juliencharrel closed 1 year ago

marceljay commented 1 year ago

It's definitely not useless, as this is a global variable, updated after every purchase, but maybe it could be renamed more adequately. I always suggest writing comments, because not writing them is actually inefficient, as other and new developers lack context. The line of code also lacks info in the commit message that could explain the usage.

juliencharrel commented 1 year ago

I know, i didn't write that code :(

marceljay commented 1 year ago

Addressed via https://github.com/closerdao/TDF-contracts/pull/43