closup / process-xbrl

An open source tool to convert ACFRs from Excel to inline XBRL
https://closup.umich.edu/acfr-tool
3 stars 1 forks source link

82 fix viewer js #84

Closed kwheelan closed 1 month ago

kwheelan commented 2 months ago

Detail

kwheelan commented 2 months ago

@lucakato Please mark as ready for review once you've had a chance to make these changes and test. I'll take a look before merging.

lucakato commented 1 month ago

@lucakato Please mark as ready for review once you've had a chance to make these changes and test. I'll take a look before merging.

Decided to go with script_tag['src'] = url_for('static', filename='js/ixbrlviewer.js') and I don't see any error messages. ixbrlviewer.js is not modified either when I tested. @kwheelan please also check the downloaded zip when doing Clayton -> Ogemaw or either way around. It's a little confusing because the Ogemaw sheet still has 'Clayton' in some cells but I believe the Ogemaw data is output correctly.

kwheelan commented 1 month ago

@lucakato Great! I tested it, and it works well for me on both templates