closup / process-xbrl

An open source tool to convert ACFRs from Excel to inline XBRL
https://closup.umich.edu/acfr-tool
3 stars 1 forks source link

Templates for Milford and Henderson and differences in output #98

Open lucakato opened 1 month ago

lucakato commented 1 month ago

In the email by Ramaswamy he filled out an old template for us for 3 different cities. For the most part, when I run it against our latest code it looks fine. For example, the values inside brackets that he said don't show do show on our latest code.

@sarraha786 Could you look into this too? If you could fill try filling out just these sections of the template I could figure out what's the issue (if there even is one).

For the following two cities there were different issues.

Henderson Ramaswamy said: 'Proprietary Funds Net Position statement - Deferred inflows and outflows of resources field is not in the template' Looking at this: ACFR_template_foonote2.xlsx template that I have, we don't have deferred inflows and outflows as a placeholder to enter data under Proprietary Funds Net Position statement so could you add this to our template, @sarraha786

Milford we don't have sub-totals(?) showing. I want to know if this is either a) an issue/feature not available with our code b) the old template he used doesn't have the section and therefore he didn't fill --> it didn't show in our output

Looking at the template he filled, my understanding is numbers such as (5,635,911) and (1,136,098) don't show because he didn't fill it in. Do you know if this is should show up if we filled it in our latest template? @sarraha786

image

Attached are the templates he filled out (using the old empty one) and PDFs containing what he expects them to look like. In the email you can find the output I get if I run them against our latest code (although this isn't that useful since it's based on an old empty template). Henderson.Excel Final.xlsx Milford.Excel Final.xlsx TX Henderson 2023.pdf UT Milford 2023.pdf

lucakato commented 1 month ago
image

Another issue with Graham county. This one is prob a code issue. Error on terminal is: image

sarraha786 commented 1 month ago

re: Milford

Here I have added subtotals and I corrected an error with the net position calculation (it was off by one row). Does this address all of their issues? If so, I'll incorporate the change across the other reconciliation statements.

Screen Shot 2024-10-07 at 1 15 13 AM
lucakato commented 1 month ago

Thanks. For the subtotals, I think so. If you could let me know when you push the new template that would be great. I think we want to open a PR and push it to dev too.

Best, Luca

@. / @.

On Mon, Oct 7, 2024 at 1:16 Sarrah Ahmed @.***> wrote:

re: Milford

Here I have added subtotals and I corrected an error with the net position calculation (it was off by one row). Does this address all of their issues? If so, I'll incorporate the change across the other reconciliation statements. Screen.Shot.2024-10-07.at.1.15.13.AM.png (view on web) https://github.com/user-attachments/assets/d70ea9a9-49f9-40d3-b36b-46f5729637aa

— Reply to this email directly, view it on GitHub https://github.com/closup/process-xbrl/issues/98#issuecomment-2395928688, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJ2QPLQ6LQENY3IZ7ORXILZ2IKIZAVCNFSM6AAAAABPD2TRHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVHEZDQNRYHA . You are receiving this because you authored the thread.Message ID: @.***>

sarraha786 commented 1 month ago

Pushed changes!

lucakato commented 1 month ago

Hey, I don’t see your changes, which branch did you push it too? And could you email the template just in case please!

Thanks

-- @. / @.

734.881.5644

214 W. 39th St., Suite 705 New York, NY 10018

LinkedIn http://linkedin.com/in/luca-kato/ | GitHub http://github.com/lucakato | Schedule a Meeting https://calendly.com/lucakato/1-on-1-call

On Mon, Oct 7, 2024 at 10:04 Sarrah Ahmed @.***> wrote:

Pushed changes!

— Reply to this email directly, view it on GitHub https://github.com/closup/process-xbrl/issues/98#issuecomment-2397027652, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJ2QPPXVGIBEIONPSI2GALZ2KIEVAVCNFSM6AAAAABPD2TRHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJXGAZDONRVGI . You are receiving this because you authored the thread.Message ID: @.***>

sarraha786 commented 1 month ago

It is issue 98, I just published it. Here is the template in case you don't see it.

On Mon, Oct 7, 2024 at 11:51 AM Luca Kato @.***> wrote:

Hey, I don’t see your changes, which branch did you push it too? And could you email the template just in case please!

Thanks

-- @. / @.

734.881.5644

214 W. 39th St., Suite 705 New York, NY 10018

LinkedIn http://linkedin.com/in/luca-kato/ | GitHub http://github.com/lucakato | Schedule a Meeting https://calendly.com/lucakato/1-on-1-call

On Mon, Oct 7, 2024 at 10:04 Sarrah Ahmed @.***> wrote:

Pushed changes!

— Reply to this email directly, view it on GitHub < https://github.com/closup/process-xbrl/issues/98#issuecomment-2397027652>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ANJ2QPPXVGIBEIONPSI2GALZ2KIEVAVCNFSM6AAAAABPD2TRHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJXGAZDONRVGI>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/closup/process-xbrl/issues/98#issuecomment-2397303140, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATD6TK3WCOL7Q5FE63PKDR3Z2KUZVAVCNFSM6AAAAABPD2TRHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJXGMYDGMJUGA . You are receiving this because you were mentioned.Message ID: @.***>

-- Sarrah Ahmed(She/Her) University of Michigan | Class of 2024 School of Information | BSI 248.971.4092 | @.*** | LinkedIn https://www.linkedin.com/in/sarrah-ahmed-b80861187/

sarraha786 commented 1 month ago

Test template- testing reconciliation balance sheet statement brackets: ACFR_template copy_test2.xlsx