search

cloud-annotations / docusaurus-openapi

🦕 OpenAPI plugin for generating API reference docs in Docusaurus v2.
https://docusaurus-openapi.netlify.app
MIT License
498 stars 82 forks source link

Fix invalid ignore pattern for underscore files #233

Closed baptisteArno closed 1 year ago

baptisteArno commented 1 year ago

Was discussed here: https://github.com/cloud-annotations/docusaurus-openapi/pull/107#discussion_r772093391

Closes #232

netlify[bot] commented 1 year ago

Deploy Preview for docusaurus-openapi ready!

Name Link
Latest commit 49c1d150dd63c249fb334dcc1af099786cc878f1
Latest deploy log https://app.netlify.com/sites/docusaurus-openapi/deploys/6384e2a235a78200090ae810
Deploy Preview https://deploy-preview-233--docusaurus-openapi.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bourdakos1 commented 1 year ago

Is GlobExcludeDefault used anywhere else? Can we just add **/_category_.{json,yaml,yml} to it so we don’t need to do the filtering or pushing of the _spec_ files?

baptisteArno commented 1 year ago

True! That should work just fine 👌

bourdakos1 commented 1 year ago

Hmm it looks like the demo isn’t picking up the _spec_ 🤔

I didn’t realize the default glob is coming directly from Docusaurus, so maybe they changed their glob in a newer version?

baptisteArno commented 1 year ago

That's a mystery for me, I checked the file history that contains the GlobIgnore pattern, it has never changed 🤔 I'll investigate and let you know

baptisteArno commented 1 year ago

It's this pattern "**/_*/**" that excludes _spec_.* files.

Let's just not rely on GlobExcludeDefault for this source fetching. It's useless.