search

cloud-ark / kubeplus

Kubernetes Operator for multi-instance multi-tenancy
https://cloudark.io/
Apache License 2.0
662 stars 82 forks source link

resolves #1167 #1176

Closed eminalparslan closed 1 year ago

eminalparslan commented 1 year ago

Installs and deletes subchart crds .

Helm charts can have subcharts in a charts directory. These subcharts may have crds of their own that need to be installed when the ResourceComposition is created and removed when the ResourceComposition is deleted. The changes simply recursively traverse the charts directory of any helm chart and install/delete any crds directory.

Fixes: https://github.com/cloud-ark/kubeplus/issues/1167

devdattakulkarni commented 1 year ago

The PR looks good.

I have one more comment on it. Can you give a more descriptive title and explanation for the PR?

Use the following structure:

One-line short description of the change blank-line A more detailed description including the context/background of the issue, and a description of the fix. blank-line Fixes: Github Issue link

If the PR is for an issue that has been already closed, then replace Fixes: Github Issue link with Updates: Github Issue link

If there is no issue created in Github, leave out the Fixes/Updates line.