Prevent CRD deletion while app instances start up.

cloud-ark / kubeplus

Kubernetes Operator for multi-instance multi-tenancy

https://cloudark.io/

Apache License 2.0

654 stars 78 forks source link

Prevent CRD deletion while app instances start up. #1183

Closed eminalparslan closed 1 year ago

eminalparslan commented 1 year ago

Deleting a CustomResourceDefinition instance also deletes the running application instances derived from that CRD. If the CRD is deleted before the application instances have started up, they won't get deleted and will be orphaned. To prevent this, we now make sure that all running application instances are ready before the CRD can be delted.

Fixes: #1182

devdattakulkarni commented 1 year ago

Looks good. One final thing -- Can you force-push the latest commit? That way, PR will have only one commit. I will then merge it.