search

cloud-ark / kubeplus

Kubernetes Operator for multi-instance multi-tenancy
https://cloudark.io/
Apache License 2.0
654 stars 78 forks source link

Remove reference to parse-api-server-url.sh from examples #1288

Closed devdattakulkarni closed 3 months ago

devdattakulkarni commented 4 months ago

Recently, we removed the parse-api-server-url.sh script and replaced it with the following more idiomatic way of obtaining the API Server URL for the Kubernetes cluster.

apiserver=kubectl config view --minify -o jsonpath='{.clusters[0].cluster.server}'`

But there are still references to parse-api-server-url.sh in the examples.

We should update all the above places to use the idiomatic approach of obtaining the API Server URL.

dsuleimenov commented 4 months ago

Hi @devdattakulkarni! Could you please review my changes related to the current issue?

Moreover, I found this place with mentioning parse-api-server-url.sh, how should the help text be updated? Maybe instead of

Use the parse-api-server-url.sh script available in KubePlus repo to get the API Server URL.

this

Use the command `kubectl config view --minify -o jsonpath='{.clusters[0].cluster.server}` to retrieve the API Server URL.
devdattakulkarni commented 4 months ago

@dsuleimenov Thanks!! I will review it later today.

devdattakulkarni commented 3 months ago

@dsuleimenov Your PR with changes to steps.txt in various example folders looked good. I have merged it. For the help text change in provider-kubeconfig.py, can you open another PR? You can modify it to the text as you have mentioned in the above comment.

dsuleimenov commented 3 months ago

Hi @devdattakulkarni! Another PR is ready for review: https://github.com/cloud-ark/kubeplus/pull/1293

devdattakulkarni commented 3 months ago

@dsuleimenov I have merged the new PR.

Thanks for your PRs. Please join us on kubeplus Slack channel to participate in project discussions. The details are in the main README.