search

cloud-bulldozer / benchmark-comparison

Project to help compare benchmark result data and system metric data provided from benchmark run.
Other
1 stars 23 forks source link

add storage csi touchstone config #68

Closed liqcui closed 1 year ago

liqcui commented 1 year ago

Description

Add storage csi touchstone config for CSI migration script, this need to be merged before PR https://github.com/openshift/svt/pull/757

Fixes

liqcui commented 1 year ago

/cc @jtaleric @jtaleric Could you please help to review my PR when you are available, thanks!

liqcui commented 1 year ago

/cc @rsevilla87

liqcui commented 1 year ago

@jtaleric Thank you for your review my PR, do you how to fix below error? or how to re-run the test? An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'fetch', 'origin', '--tags') return code: 128 stdout: (none) stderr: fatal: could not read Username for 'https://gitlab.com/': No such device or address Check the log at /home/runner/.cache/pre-commit/pre-commit.log Error: The process '/opt/hostedtoolcache/Python/3.8.16/x64/bin/pre-commit' failed with exit code 3

rsevilla87 commented 1 year ago

@jtaleric Thank you for your review my PR, do you how to fix below error? or how to re-run the test? An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'fetch', 'origin', '--tags') return code: 128 stdout: (none) stderr: fatal: could not read Username for 'https://gitlab.com/': No such device or address Check the log at /home/runner/.cache/pre-commit/pre-commit.log Error: The process '/opt/hostedtoolcache/Python/3.8.16/x64/bin/pre-commit' failed with exit code 3

Hey!, ci tests are not relevant here since this is just a new config addition and not a code change. I assume you've tested the configuration file so we can merge this patch.

liqcui commented 1 year ago

@jtaleric Thank you for your review my PR, do you how to fix below error? or how to re-run the test? An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'fetch', 'origin', '--tags') return code: 128 stdout: (none) stderr: fatal: could not read Username for 'https://gitlab.com/': No such device or address Check the log at /home/runner/.cache/pre-commit/pre-commit.log Error: The process '/opt/hostedtoolcache/Python/3.8.16/x64/bin/pre-commit' failed with exit code 3

Hey!, ci tests are not relevant here since this is just a new config addition and not a code change. I assume you've tested the configuration file so we can merge this patch.

Yes, the configuration file has been tested, thanks!