search

cloud-bulldozer / benchmark-operator

The Chuck Norris of cloud benchmarks
Apache License 2.0
285 stars 129 forks source link

Use cluster-admin ClusterRoleBinding #763

Closed rsevilla87 closed 2 years ago

rsevilla87 commented 2 years ago

Signed-off-by: Raul Sevilla rsevilla@redhat.com

Description

I think it's better to use a cluster-admin ClusterRole. At the moment it's difficult to manage the permissions required by most of benchmarks. Some of them already have privileged permissions, their own Roles/Bindings files, etc. We should reduce the amount of things we manage.

I know this is not a security-friendly practice, but running performance benchmarks in a cluster is 99% of cases executed by a cluster's administrator

This should simplify the things a little bit.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@61f325e). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #763   +/-   ##
=========================================
  Coverage          ?   53.47%           
=========================================
  Files             ?        8           
  Lines             ?      331           
  Branches          ?        0           
=========================================
  Hits              ?      177           
  Misses            ?      154           
  Partials          ?        0
Flag Coverage Δ
gha 53.47% <0.00%> (?)
python-3.9 53.47% <0.00%> (?)
unit 53.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61f325e...e15c19f. Read the comment docs.