search

cloud-bulldozer / benchmark-operator

The Chuck Norris of cloud benchmarks
Apache License 2.0
285 stars 129 forks source link

bug fix for ports mismatch between client and server pairs in without… #774

Closed vishnuchalla closed 2 years ago

vishnuchalla commented 2 years ago

Description

Context : https://github.com/cloud-bulldozer/benchmark-operator/issues/773

Fixes

Made code changes to assign correct ports to client-server pairs.

Testing

Tested for multiple cases. Below are the uuids to check in ES cluster here&_a=(columns:!(_source),filters:!(),index:c842dec0-50f4-11eb-ab97-59afc90e99be,interval:auto,query:(language:lucene,query:''),sort:!())).

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6fa2b25). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #774   +/-   ##
=========================================
  Coverage          ?   53.47%           
=========================================
  Files             ?        8           
  Lines             ?      331           
  Branches          ?        0           
=========================================
  Hits              ?      177           
  Misses            ?      154           
  Partials          ?        0
Flag Coverage Δ
gha 53.47% <0.00%> (?)
python-3.9 53.47% <0.00%> (?)
unit 53.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fa2b25...f900613. Read the comment docs.

vishnuchalla commented 2 years ago

Good! Hope nodeport type logic is intact.

Yes. test that as well