cloud-bulldozer / benchmark-operator

The Chuck Norris of cloud benchmarks
Apache License 2.0
285 stars 129 forks source link

Uperf scale mode code changes #776

Closed vishnuchalla closed 2 years ago

vishnuchalla commented 2 years ago

Description

Code changes for uperf scale mode. These code changes contain a uperf-scale role altogether separate from the existing upef workload.

Context: https://github.com/cloud-bulldozer/benchmark-operator/pull/525

Testing

Sample CR

apiVersion: ripsaw.cloudbulldozer.io/v1alpha1
kind: Benchmark
metadata:
  name: uperf-scale-benchmark
  namespace: benchmark-operator
spec:
  clustername: myk8scluster
  elasticsearch:
    url: https://search-perfscale-dev-chmf5l4sh66lvxbnadi4bznl3a.us-west-2.es.amazonaws.com:443
  workload:
    name: uperf-scale
    args:
      hostnetwork: true
      serviceip: true
      servicetype: "nodeport"
      networkpolicy: true
      multus:
        enabled: false
      samples: 1
      kind: pod
      test_types:
        - stream
      protos:
        - tcp
      sizes:
        - 16384
      nthrs:
        - 1
      runtime: 30
      colocate: true
      density_range: [1, 5]
      node_range: [1, 5]
      step_size: add1

Tested for all possible scenarios. Below are the uuids to check in ES cluster here&_a=(columns:!(_source),filters:!(),index:c842dec0-50f4-11eb-ab97-59afc90e99be,interval:auto,query:(language:lucene,query:''),sort:!())).

6807088c-f59c-5dd8-a9cc-4b43bfff4f4c - Scale mode without service 0628446a-2571-5ff2-9482-6f5c08032f5a - Scale mode with clusterip service 98ae3edc-944d-5bec-8f4b-9b807ca768e0 - Scale mode with nodeport service 3be3d070-562b-5942-b2a5-450483ed8926 - Scale mode with network policy 2647411c-c40a-58a2-8ee1-c1122d4d65d5 - Scale mode with resources

And also verified the results in the client pod using the below script. The below script can also be used for verification on the reviewers side as well.

echo -n "`oc get all | grep -i -e 'completed' | cut -f 1 -d ' '`" > output.txt

cat output.txt | awk '{print $0}' | while
    read each
do
    echo "client name: $each"
    echo "client info"
    echo -n "`oc get $each -o yaml | grep -i -e "clientfor" -e 'port' -A 2`"
    echo -e "\n"
    echo "client logs"
    echo -n "`oc logs $each | tail -n 5`"
    echo -e "\n\n"
done
codecov-commenter commented 2 years ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.17%. Comparing base (94005cd) to head (b1432f0). Report is 25 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #776 +/- ## ========================================== - Coverage 53.47% 53.17% -0.31% ========================================== Files 8 8 Lines 331 331 ========================================== - Hits 177 176 -1 - Misses 154 155 +1 ``` | [Flag](https://app.codecov.io/gh/cloud-bulldozer/benchmark-operator/pull/776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloud-bulldozer) | Coverage Δ | | |---|---|---| | [gha](https://app.codecov.io/gh/cloud-bulldozer/benchmark-operator/pull/776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloud-bulldozer) | `53.17% <ø> (-0.31%)` | :arrow_down: | | [python-3.9](https://app.codecov.io/gh/cloud-bulldozer/benchmark-operator/pull/776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloud-bulldozer) | `53.17% <ø> (-0.31%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/cloud-bulldozer/benchmark-operator/pull/776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloud-bulldozer) | `53.17% <ø> (-0.31%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloud-bulldozer#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.