search

cloud-bulldozer / benchmark-operator

The Chuck Norris of cloud benchmarks
Apache License 2.0
282 stars 127 forks source link

Added exit status for uperf failures #782

Closed vishnuchalla closed 2 years ago

vishnuchalla commented 2 years ago

Description

Context: https://github.com/cloud-bulldozer/benchmark-operator/issues/773 Realted Wrapper PR: https://github.com/cloud-bulldozer/benchmark-wrapper/pull/439 Adding exit status for uperf failure cases. This change needs to be integrated in all the workloads that use sanfu for execution as a future action item.

Fixes

Made code changes to return a non-zero exit in case of failures.

Testing

Tested it integrating with benchmark-wrapper.

Screenshots

mukrishn commented 2 years ago

@vishnuchalla can you fix the conflict and update the failure task to use the common role benchmark_state like in PR #781

vishnuchalla commented 2 years ago

@vishnuchalla can you fix the conflict and update the failure task to use the common role benchmark_state like in PR #781

Done. Resolved the conflicts and used benchmark_state

codecov-commenter commented 2 years ago

Codecov Report

Merging #782 (75450d8) into master (94005cd) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   53.47%   53.47%           
=======================================
  Files           8        8           
  Lines         331      331           
=======================================
  Hits          177      177           
  Misses        154      154
Flag Coverage Δ
gha 53.47% <ø> (ø)
python-3.9 53.47% <ø> (ø)
unit 53.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94005cd...75450d8. Read the comment docs.