search

cloud-bulldozer / benchmark-operator

The Chuck Norris of cloud benchmarks
Apache License 2.0
282 stars 127 forks source link

fixing port conflict for uperf bidrec test #786

Closed vishnuchalla closed 2 years ago

vishnuchalla commented 2 years ago

Description

Context: https://github.com/cloud-bulldozer/benchmark-operator/issues/780

Fixes

Assigning a different port for the reverse test so that it doesn't conflict with the forward test port.

Testing screenshot

Screenshot from 2022-07-11 21-42-15

codecov-commenter commented 2 years ago

Codecov Report

Merging #786 (4d06e47) into master (94005cd) will decrease coverage by 0.30%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
- Coverage   53.47%   53.17%   -0.31%     
==========================================
  Files           8        8              
  Lines         331      331              
==========================================
- Hits          177      176       -1     
- Misses        154      155       +1
Flag Coverage Δ
gha 53.17% <ø> (-0.31%) :arrow_down:
python-3.9 53.17% <ø> (-0.31%) :arrow_down:
unit 53.17% <ø> (-0.31%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/ripsaw/clients/k8s.py 90.00% <0.00%> (-1.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12701a6...4d06e47. Read the comment docs.

mukrishn commented 2 years ago

@vishnuchalla LGTM, squash all commits in to single commit.