cloud-bulldozer / benchmark-operator

The Chuck Norris of cloud benchmarks
Apache License 2.0
282 stars 127 forks source link

Race condition in FIO #792

Closed jtaleric closed 2 years ago

jtaleric commented 2 years ago

With FIO we need to wait for server pods to be annotated with IP addresses. This fix adds that wait.

closes #789

Signed-off-by: Joe Talerico jtaleric@redhat.com

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d8672e9). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #792   +/-   ##
=========================================
  Coverage          ?   53.47%           
=========================================
  Files             ?        8           
  Lines             ?      331           
  Branches          ?        0           
=========================================
  Hits              ?      177           
  Misses            ?      154           
  Partials          ?        0           
Flag Coverage Δ
gha 53.47% <0.00%> (?)
python-3.9 53.47% <0.00%> (?)
unit 53.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

shekharberry commented 2 years ago

I tested this PR on my Openshift cluster and I see FIO client pod being created. FIO test ran and completed successfully.