search

cloud-bulldozer / benchmark-operator

The Chuck Norris of cloud benchmarks
Apache License 2.0
282 stars 127 forks source link

Added StorageClass support to Sysbench #799

Closed kdvalin closed 1 year ago

kdvalin commented 1 year ago

Description

This PR adds the ability to run sysbench in a CR defined SC. If a SC is not provided, the volume defaults to emptyDir type, as it was doing previously.

It also adds the ability to define options for each phase of fileio test. The current parameters act as global parameters, and then it breaks out into <prepare/run/cleanup>_parameters that override the global parameters, if you want to remove a global parameter from a phase of the test, providing null for the option in the YAML file achieves this.

Fixes

Adds CR defend SC selection for sysbench. Creates PVC for the selected SC with CR defined size for sysbench.

shekharberry commented 1 year ago

I have tried this fix and it worked fine for me. No issues seen.

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

shekharberry commented 1 year ago

@kdvalin Can you provide an update here?? IMO this worked smoothly during my testing and it should be merged.

@jtaleric who would be responsible to merge this PR ??

codecov-commenter commented 1 year ago

Codecov Report

Merging #799 (0f1911c) into master (68671d1) will decrease coverage by 0.31%. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   53.47%   53.17%   -0.31%     
==========================================
  Files           8        8              
  Lines         331      331              
==========================================
- Hits          177      176       -1     
- Misses        154      155       +1
Flag Coverage Δ
gha 53.17% <ø> (-0.31%) :arrow_down:
python-3.9 53.17% <ø> (-0.31%) :arrow_down:
unit 53.17% <ø> (-0.31%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/ripsaw/clients/k8s.py 90.00% <0.00%> (-1.12%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.