cloud-bulldozer / benchmark-operator

The Chuck Norris of cloud benchmarks
Apache License 2.0
282 stars 127 forks source link

Fixing BMO for CNV #823

Closed jtaleric closed 5 months ago

jtaleric commented 5 months ago

Type of change

Description

CNV w/ OpenShift 4.15 was broken. This should fix it.

Related Tickets & Documents

Checklist before requesting a review

Testing

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.17%. Comparing base (0954437) to head (cba1158). Report is 10 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #823 +/- ## ======================================= Coverage 53.17% 53.17% ======================================= Files 8 8 Lines 331 331 ======================================= Hits 176 176 Misses 155 155 ``` | [Flag](https://app.codecov.io/gh/cloud-bulldozer/benchmark-operator/pull/823/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloud-bulldozer) | Coverage Δ | | |---|---|---| | [gha](https://app.codecov.io/gh/cloud-bulldozer/benchmark-operator/pull/823/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloud-bulldozer) | `53.17% <ø> (ø)` | | | [python-3.9](https://app.codecov.io/gh/cloud-bulldozer/benchmark-operator/pull/823/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloud-bulldozer) | `53.17% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/cloud-bulldozer/benchmark-operator/pull/823/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloud-bulldozer) | `53.17% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloud-bulldozer#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ebattat commented 5 months ago

/LGTM, @jtaleric, Could you please create a separate release after merging ? https://github.com/cloud-bulldozer/benchmark-operator/releases/tag/v1.0.3