search

cloud-bulldozer / benchmark-wrapper

Python Library to run benchmarks
https://benchmark-wrapper.readthedocs.io
Apache License 2.0
19 stars 56 forks source link

IOPS floating-point truncation to int results in significant fio errors #336

Closed bengland2 closed 3 years ago

bengland2 commented 3 years ago

Do not merge yet, testing, I'll merge as soon as I see it work.

IOPS results in ripsaw-fio-analyzed-result index were way less than sum of per-job (per-process) IOPS results with numjobs=32, this was because the tests in question had per-process IOPS < 1 for 4096-KiB writes, in some cases so int() truncated them to zero. In most cases this does not result in such a noticeable error.

codecov-commenter commented 3 years ago

Codecov Report

Merging #336 (605f015) into master (2ca9886) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   41.87%   41.87%           
=======================================
  Files          15       15           
  Lines         905      905           
=======================================
  Hits          379      379           
  Misses        526      526
Flag Coverage Δ
gha 41.87% <ø> (ø)
python-3.6 41.87% <ø> (ø)
unit 41.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ca9886...605f015. Read the comment docs.

bengland2 commented 3 years ago

I verified that it worked by comparing results in grafana to results from analyze-fio-test-results.py for same UUID, it matched exactly, and the right values were also in the ripsaw-fio-analyzed-results index.

bengland2 commented 3 years ago

please merge now, urgent, I lost the merge button here too.