search

cloud-bulldozer / benchmark-wrapper

Python Library to run benchmarks
https://benchmark-wrapper.readthedocs.io
Apache License 2.0
19 stars 56 forks source link

Fix Various Bugs in GHA Build Workflow #342

Closed learnitall closed 3 years ago

learnitall commented 3 years ago

Description

Upon merging https://github.com/cloud-bulldozer/benchmark-wrapper/pull/319 I found various bugs still leftover. This PR fixes them.

Fixes

  1. Bad regex strings in ci/build_matrix.py that would have lead to false negatives for changes in core snafu components.
  2. Bad logic in the workflow for enabling the --changed-only parameter.
codecov-commenter commented 3 years ago

Codecov Report

Merging #342 (d8588ac) into master (c87ecbc) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   39.40%   39.40%           
=======================================
  Files          15       15           
  Lines         868      868           
=======================================
  Hits          342      342           
  Misses        526      526
Flag Coverage Δ
gha 39.40% <ø> (ø)
python-3.6 39.40% <ø> (ø)
unit 39.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c87ecbc...d8588ac. Read the comment docs.