search

cloud-bulldozer / benchmark-wrapper

Python Library to run benchmarks
https://benchmark-wrapper.readthedocs.io
Apache License 2.0
19 stars 56 forks source link

change uperf_ts to timestamp as other workloads timestamp #349

Closed ebattat closed 2 years ago

ebattat commented 3 years ago

Description

change uperf_ts to timestamp as other workloads timestamp

Fixes

That current Elasticsearch variable for timestamp is uperf_ts. The best practice is to use 'timestamp' instead of 'uperf_ts' Also this is the timestamp variable name in other workloads (stressng, hammerdb)

comet-perf-ci commented 3 years ago

Can one of the admins verify this patch?

rsevilla87 commented 2 years ago

@ebattat I'm mostly agree with this change, we should transition from uperf_ts to a more standard field named timestamp. However as @jtaleric this implementation is not right, as the actual timestamp is figured from the uperf log traces.

rsevilla87 commented 2 years ago

Addressed by https://github.com/cloud-bulldozer/benchmark-wrapper/pull/425