search

cloud-bulldozer / benchmark-wrapper

Python Library to run benchmarks
https://benchmark-wrapper.readthedocs.io
Apache License 2.0
19 stars 56 forks source link

When counting workers, we need to skip workload and infra nodes #351

Closed morenod closed 3 years ago

morenod commented 3 years ago 
[morenod@morenod-laptop benchmark-wrapper]$ oc get nodes
NAME                                         STATUS   ROLES             AGE     VERSION
ip-10-0-129-100.us-west-2.compute.internal   Ready    worker            5d23h   v1.21.1+9807387
ip-10-0-135-251.us-west-2.compute.internal   Ready    infra,worker      7d1h    v1.21.1+9807387
ip-10-0-138-40.us-west-2.compute.internal    Ready    worker,workload   5d23h   v1.21.1+9807387
ip-10-0-141-182.us-west-2.compute.internal   Ready    master            7d1h    v1.21.1+9807387
ip-10-0-166-165.us-west-2.compute.internal   Ready    infra,worker      7d1h    v1.21.1+9807387
ip-10-0-170-115.us-west-2.compute.internal   Ready    master            7d1h    v1.21.1+9807387
ip-10-0-170-26.us-west-2.compute.internal    Ready    worker,workload   5d23h   v1.21.1+9807387
ip-10-0-175-28.us-west-2.compute.internal    Ready    worker            5d22h   v1.21.1+9807387
ip-10-0-194-87.us-west-2.compute.internal    Ready    infra,worker      7d1h    v1.21.1+9807387
ip-10-0-206-22.us-west-2.compute.internal    Ready    worker            7d1h    v1.21.1+9807387
ip-10-0-216-216.us-west-2.compute.internal   Ready    master            7d1h    v1.21.1+9807387
ip-10-0-221-164.us-west-2.compute.internal   Ready    worker,workload   5d23h   v1.21.1+9807387

If we set to scale to 9, wrapper consider that it is already on 9, because it is including infra and workload workers on the count. We need to skip those nodes from the count

codecov-commenter commented 3 years ago

Codecov Report

Merging #351 (b82da43) into master (8b69368) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   39.40%   39.40%           
=======================================
  Files          15       15           
  Lines         868      868           
=======================================
  Hits          342      342           
  Misses        526      526
Flag Coverage Δ
gha 39.40% <ø> (ø)
python-3.6 39.40% <ø> (ø)
unit 39.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b69368...b82da43. Read the comment docs.

comet-perf-ci commented 3 years ago

Results for SNAFU CI Test

Test Result Runtime
snafu/scale_openshift_wrapper PASS 00:09:01