cloud-bulldozer / benchmark-wrapper

Python Library to run benchmarks
https://benchmark-wrapper.readthedocs.io
Apache License 2.0
19 stars 56 forks source link

Update sed command for additional workloads #393

Closed dry923 closed 2 years ago

dry923 commented 2 years ago

Description

CI was not properly being run on image pull and log generator workloads because the image strings were not getting updated.

Fixes

CI was not working for image pull and log generator

comet-perf-ci commented 2 years ago

Results for SNAFU CI Test

Test Result Runtime
fail No CI test 00:00:00
sjug commented 2 years ago

Looks like a good place to use a loop 😉

dry923 commented 2 years ago

@sjug We should really just utilize the image override function in the benchmark operator workload yaml files but yeah. ie { workload: image: my_image_location }

But for the moment I just want it to work so the other pip fixes can pass and be merged. Then we need to revisit CI across the baord since the wrapper and operator also conflict with each other when run at the same time...