search

cloud-bulldozer / benchmark-wrapper

Python Library to run benchmarks
https://benchmark-wrapper.readthedocs.io
Apache License 2.0
19 stars 56 forks source link

Updates tag for smallfile image #394

Closed chentex closed 2 years ago

chentex commented 2 years ago

Signed-off-by: Vicente Zepeda Mas vzepedam@redhat.com

Description

This is related to: https://github.com/cloud-bulldozer/benchmark-operator/pull/711

Since the tag is being updated in that PR we need to update it here as well for tests to run

Fixes

codecov-commenter commented 2 years ago

Codecov Report

Merging #394 (ca66be9) into master (4755494) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          15       15           
  Lines         869      869           
=======================================
  Hits          342      342           
  Misses        527      527
Flag Coverage Δ
gha 39.35% <ø> (ø)
python-3.6 39.35% <ø> (ø)
unit 39.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4755494...ca66be9. Read the comment docs.

dry923 commented 2 years ago

@sjug a couple quick thoughts on this 1/2) re the bash loop I'm 100% on board w/ that assuming we align the images on latest. At this point I don't think there would be any reason to keep than on anything else. 3) There is an existing issue around that https://github.com/cloud-bulldozer/benchmark-wrapper/issues/347

chentex commented 2 years ago

Superseded by https://github.com/cloud-bulldozer/benchmark-wrapper/pull/396