cloud-bulldozer / benchmark-wrapper

Python Library to run benchmarks
https://benchmark-wrapper.readthedocs.io
Apache License 2.0
19 stars 56 forks source link

Add summary output for uperf #404

Closed jtaleric closed 2 years ago

jtaleric commented 2 years ago

Description

Uperf spews raw per-second data to the screen. Instead, we should provide a summary of the results.

The only issue here, is the user doesn't have the contextg of what the test was, since it is in XML and read in via a file. This could be later improved to read in the XML to understand the sort of test.

Fixes

codecov-commenter commented 2 years ago

Codecov Report

Merging #404 (8dbb3b8) into master (b8ccd6e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          15       15           
  Lines         869      869           
=======================================
  Hits          342      342           
  Misses        527      527           
Flag Coverage Δ
gha 39.35% <ø> (ø)
python-3.6 39.35% <ø> (ø)
unit 39.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8ccd6e...8dbb3b8. Read the comment docs.

jtaleric commented 2 years ago

Not sure why that check is failing, as it succeeds locally?

(rook) jtaleric at rook-mobile in ~/dev/snafu on uperf-summary* $ black snafu/benchmarks/uperf/uperf.py
All done! ✨ 🍰 ✨
1 file left unchanged.
jtaleric commented 2 years ago

/rerun all

mohit-sheth commented 2 years ago

pre-commit.ci autofix

learnitall commented 2 years ago

@jtaleric Snafu's black config is set in the pre-commit config, which isn't picked up by running black on its own. To run black with snafu's config, do a pre-commit run black.

jtaleric commented 2 years ago

Thanks @learnitall!!