cloud-bulldozer / benchmark-wrapper

Python Library to run benchmarks

https://benchmark-wrapper.readthedocs.io

Apache License 2.0

19 stars 56 forks source link

get fs-drift to pass CI again #414

Closed bengland2 closed 2 years ago

bengland2 commented 2 years ago

this is not a real fix, we need to process response time data and process counter data into rates over time but at least the code is structured more reasonably now JSON parsing is removed from this module can be fixed later as time and interest permits

bengland2 commented 2 years ago

ok this is strange error message, all 6 checks above pass but the message is "8 successful and 1 failing check"???

codecov-commenter commented 2 years ago

Codecov Report

Merging #414 (70621d4) into master (13cb786) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #414   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          15       15           
  Lines         869      869           
=======================================
  Hits          342      342           
  Misses        527      527

Flag	Coverage Δ
gha	`39.35% <ø> (ø)`
python-3.6	`39.35% <ø> (ø)`
unit	`39.35% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13cb786...70621d4. Read the comment docs.

bengland2 commented 2 years ago

I have pushed a real fix to fs-drift benchmark-wrapper above (as well as pushing a fix to fs-drift benchmark itself). investigating pre-commit.ci error during build while testing my hand-built image (which built successfully).

bengland2 commented 2 years ago

The error during build is nothing to do with me, it is CI system not being able to authenticate itself. Please help.

bengland2 commented 2 years ago

this is ready to merge, has been tested in AWS with fs-drift and OCP 4.9 . The one CI check above that failed is nothing to do with fs-drift. Can someone please merge this?

bengland2 commented 2 years ago

what did I do wrong to cause CI not to pass? Last night the image build failed with github authentication error. Screenshot from 2022-03-15 15-27-23

bengland2 commented 2 years ago

/rerun all

learnitall commented 2 years ago

Issue lies with our pre-commit config, I'll push a fix here in a second.

learnitall commented 2 years ago

@bengland2 can you merge in the updated pre-commit config from master?

bengland2 commented 2 years ago

@learnitall I rebased my changes and it still fails but for reasons I can do something about now, thank you!

learnitall commented 2 years ago

Thank you for your patience with the pre-commit issues. TIL to stay up to date on GitHub's blog to stay informed on these sorts of changes.