search

cloud-bulldozer / go-commons

Code repository with all go common packages and libraries
Apache License 2.0
4 stars 9 forks source link

Remove useless variables #10

Closed rsevilla87 closed 1 year ago

rsevilla87 commented 1 year ago

Description

There're several variables that can be removed, b/c they are not used or their behavious should be handled externally by the application consuming these libraries.

vishnuchalla commented 1 year ago

Looks good to me. After cutting a new release on this change, we need to update k8s-netperf here.

rsevilla87 commented 1 year ago

Looks good to me. After cutting a new release on this change, we need to update k8s-netperf here.

yes, same will happen with kube-burner. anyway, cutting a new release, doesn't mean the dependents to automatically use the last one