search

cloud-bulldozer / go-commons

Code repository with all go common packages and libraries
Apache License 2.0
4 stars 9 forks source link

The indexer shouldn't know about JobNames #13

Closed rsevilla87 closed 1 year ago

rsevilla87 commented 1 year ago

Description

JobName is a kube-burner thing, we should handle it from the app and not from here.

rsevilla87 commented 1 year ago

sgtm - only one thought is if we wanted to start to have standard metadata across tools... like ocpVersion and soon I will add ocpShortVersion to k8s-netperf, but maybe we want something for consistency?

agree, but isn't it out of scope of this PR? 😃

vishnuchalla commented 1 year ago

lgtm. Thanks for this change.

jtaleric commented 1 year ago

sgtm - only one thought is if we wanted to start to have standard metadata across tools... like ocpVersion and soon I will add ocpShortVersion to k8s-netperf, but maybe we want something for consistency?

agree, but isn't it out of scope of this PR? smiley

I wasn't suggesting this PR needed this, just a random thought really.