adding go unit tests to the workflow

cloud-bulldozer / go-commons

Code repository with all go common packages and libraries

Apache License 2.0

4 stars 9 forks source link

adding go unit tests to the workflow #19

Closed vishnuchalla closed 1 year ago

vishnuchalla commented 1 year ago

Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] Optimization
[ ] Documentation Update

Description

Related Tickets & Documents

Related Issue # https://github.com/cloud-bulldozer/go-commons/issues/12
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Tested through the CI

vishnuchalla commented 1 year ago

@shashank-boyapally indexers tests seems to be flaky. Requesting to take a look. Thank you

shashank-boyapally commented 1 year ago

The reason this has happened is as we randomized the tests(all in context of local.go), sometimes Index() is being called before new() which is seldom in a real world situation, but in order to mitigate this problem I've taken care of creating the placeholder dir whenever Index is being called by which this unexpected error can be avoided. Please look into the changes, Thank you.

vishnuchalla commented 1 year ago

I see all the code good, the only thing I see weird is that merge to main commit that you have, fae7f3727b332f27e72aeb44ef6d53604846845e, maybe you need to rebase your working branch.

I tried rebasing but there seems to be having lot many conflicts. So opened up a new one: https://github.com/cloud-bulldozer/go-commons/pull/20