K8s metadata - Githubissues

cloud-bulldozer / go-commons

Code repository with all go common packages and libraries

Apache License 2.0

4 stars 9 forks source link

Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[x] Optimization
[ ] Documentation Update

Description

Some updates required to make this library compatible with vanilla k8s

When infrastructure or the clusterversion resources are not found, assume that this is not an OCP cluster and return empty fields rather than crashing
Omitting empty metadata fields
Count control-plane nodes as masters

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dc2da49) 83.33% compared to head (7840ef7) 83.33%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #38 +/- ## ======================================= Coverage 83.33% 83.33% ======================================= Files 6 6 Lines 312 312 ======================================= Hits 260 260 Misses 38 38 Partials 14 14 ```