Adds new metadata values

cloud-bulldozer / go-commons

Code repository with all go common packages and libraries

Apache License 2.0

4 stars 9 forks source link

Adds new metadata values #40

Closed chentex closed 6 months ago

chentex commented 10 months ago

Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] Optimization
[ ] Documentation Update

Description

Includes FIPS, Publish, and Architecture extraction

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

jtaleric commented 10 months ago

Curious, what is Publish?

chentex commented 10 months ago

Curious, what is Publish?

It tells you if the cluster is External or Private facing, I'm open to new names

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.06%. Comparing base (0140b10) to head (6e5e424).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #40 +/- ## ========================================== + Coverage 84.66% 86.06% +1.40% ========================================== Files 6 6 Lines 339 287 -52 ========================================== - Hits 287 247 -40 + Misses 38 26 -12 Partials 14 14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vishnuchalla commented 7 months ago

Curious, what is Publish?

It tells you if the cluster is External or Private facing, I'm open to new names

if its just a bool, can we rename it as isPublic or something?

chentex commented 7 months ago

Resolved all the comments.