cloud-bulldozer / go-commons

Code repository with all go common packages and libraries
Apache License 2.0
4 stars 9 forks source link

[RFE] Baremetal fill for masterNodeType #46

Open josecastillolema opened 1 week ago

josecastillolema commented 1 week ago

Currently the Grafana dashboards linked in the CPT dashboard are broken for the bare metal platform because they lack the masterNodeType field (https://github.com/cloud-bulldozer/go-commons/blob/main/ocp-metadata/ocp-metadata.go#L265).

It would be great to fill this field for bare metal deployments also, some standard key like i.e.: baremetal of just any non empty string, i.e.: - will do.

rsevilla87 commented 3 days ago

I've removed the masterNodeType filter from the grafana dashboard, this filter wasn't 100% necessary and was generating headaches like this