cloud-bulldozer / go-commons

Code repository with all go common packages and libraries
Apache License 2.0
4 stars 9 forks source link

[PERFSCALE-3398] Ocp virt version #51

Open rsevilla87 opened 6 days ago

rsevilla87 commented 6 days ago

Type of change

Description

From the different alternatives to get the version I've tested, I think this one is the more reliable and simple.

Using the csv could work, but the name of the csv is not consistent, and changes with the deployed version, which makes the logic more complex:

 $ oc get csv -n openshift-cnv
NAME                                       DISPLAY                    VERSION   REPLACES                                   PHASE
kubevirt-hyperconverged-operator.v4.17.1   OpenShift Virtualization   4.17.1    kubevirt-hyperconverged-operator.v4.17.0   Succeeded

Something similar with the installplan

$ oc get installplan -A
NAMESPACE       NAME            CSV                                        APPROVAL    APPROVED
openshift-cnv   install-rhjt5   kubevirt-hyperconverged-operator.v4.17.1   Automatic   true
codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.23%. Comparing base (7b66b75) to head (ac5a635).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #51 +/- ## ======================================= Coverage 82.23% 82.23% ======================================= Files 6 6 Lines 349 349 ======================================= Hits 287 287 Misses 48 48 Partials 14 14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.