Publish multi-arch container images

cloud-bulldozer / k8s-netperf

Running Networking Performance Tests against K8s

Apache License 2.0

28 stars 17 forks source link

Publish multi-arch container images #101

Closed krishvoor closed 1 year ago

krishvoor commented 1 year ago

This PR introduces a PR, to build & publish ARM64 & AMD64 container images to quay.io/cloud-bulldozer/netperf

Type of change

[ ] Refactor
[X] New feature
[ ] Bug fix
[ ] Optimization
[ ] Documentation Update

Description

This PR introduces changes to build, publish container images (ARM64 & AMD64) to quay.io/cloud-bulldozer/netperf repository

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

krishvoor commented 1 year ago

@jtaleric Some initial thoughts I jotted together from my prior experiences on publishing a multi-arch image. Though this is WIP, can you take a look/review?

jtaleric commented 1 year ago

Should we have this be a net-new action versus adding to the goreleaser action?

krishvoor commented 1 year ago

I wanted this to be under the same umbrella/file to have a logical release flow, if you think we shd bifurcate these actions and maintain another file, sure can do it.

jtaleric commented 1 year ago

I wanted this to be under the same umbrella/file to have a logical release flow, if you think we shd bifurcate these actions and maintain another file, sure can do it.

Well these are two different paths.

GoReleaser- Builds the binary for k8s-netperf containers/Dockerfile - is the netperf binary, which k8s-netperf sets as the container image for the client/server.

krishvoor commented 1 year ago

I wanted this to be under the same umbrella/file to have a logical release flow, if you think we shd bifurcate these actions and maintain another file, sure can do it.

Well these are two different paths.

GoReleaser- Builds the binary for k8s-netperf containers/Dockerfile - is the netperf binary, which k8s-netperf sets as the container image for the client/server.

Ok, I have updated ptal!

jtaleric commented 1 year ago

is this still a WIP?