Fix container and manifest targets in makefile - Githubissues

cloud-bulldozer / k8s-netperf

Running Networking Performance Tests against K8s

Apache License 2.0

28 stars 17 forks source link

Fix container and manifest targets in makefile #137

Closed rsevilla87 closed 6 months ago

rsevilla87 commented 6 months ago

Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[ ] Optimization
[ ] Documentation Update

Description

Some targets are broken:

CONTAINER_NS doesn't is concatenated with $(BIN)
There's no need to use the flat -t when building a manifest with multiple platforms/archs
Adding the tag :latest to the container image, it's automatically added, but is helps on readability

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.
gha-push location was incorrect