cloud-bulldozer / performance-dashboards

Performance dashboards from the Perf & Scale team
Apache License 2.0
16 stars 36 forks source link

Adding Public - UPerf Results dashboard to grafonnet. #109

Closed smandaRH closed 5 months ago

smandaRH commented 5 months ago

Type of change

Description

Adding Public - UPerf Results dashboard to grafonnet.

Related Tickets & Documents

Checklist before requesting a review

Testing

smandaRH commented 5 months ago

@vishnuchalla

old dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/noO0pWhSk/public-uperf-results?orgId=1

new dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/caF0pZ2Sk/public-uperf-results-dashboard?orgId=1&refresh=30s

vishnuchalla commented 5 months ago

@vishnuchalla

old dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/noO0pWhSk/public-uperf-results?orgId=1

new dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/caF0pZ2Sk/public-uperf-results-dashboard?orgId=1&refresh=30s

Hosting these dashboards on your own cluster is not useful when they have elasticsearch as data source. Can you use your dev grafana instance instead to host them for testing and PR review purposes please?

smandaRH commented 5 months ago

old dashboard: https://grafana.rdu2.scalelab.redhat.com:3000/d/bca19562-2624-4102-bdd1-da7ac8561532/public-uperf-results-old?orgId=1

new dashboard: https://grafana.rdu2.scalelab.redhat.com:3000/d/b07cef83-826a-4f87-819b-0cd8529743ef/public-uperf-results-dashboard-new?orgId=1&refresh=30s

vishnuchalla commented 5 months ago

old dashboard: https://grafana.rdu2.scalelab.redhat.com:3000/d/bca19562-2624-4102-bdd1-da7ac8561532/public-uperf-results-old?orgId=1

new dashboard: https://grafana.rdu2.scalelab.redhat.com:3000/d/b07cef83-826a-4f87-819b-0cd8529743ef/public-uperf-results-dashboard-new?orgId=1&refresh=30s

I just took a look at both the dashboards side by side, Values in UPerf Result Summary --> message_size column are completely irrelevant. Can you please cross check everything again and correct them?

smandaRH commented 5 months ago

image

here in the old dashboard the message_size is mentioned exact number. but in the new one it is rounding off to value and giving the B/s. 16384 is 16.4k (16400).

vishnuchalla commented 5 months ago

image

here in the old dashboard the message_size is mentioned exact number. but in the new one it is rounding off to value and giving the B/s. 16384 is 16.4k (16400).

Yes can you please correct that? Also message size in Kb/s doesn't make sense.

smandaRH commented 5 months ago

please refer to these links, updated the requested changes

old dashboard: https://grafana.rdu2.scalelab.redhat.com:3000/d/f97539fd-8528-43c6-8fa4-ab34d81db679/public-uperf-results-old?orgId=1

new dashboard: https://grafana.rdu2.scalelab.redhat.com:3000/d/c592a5b3-2b88-45a2-acfc-85cd3a1dae6b/public-uperf-results-dashboard-new?orgId=1