cloud-bulldozer / performance-dashboards

Performance dashboards from the Perf & Scale team
Apache License 2.0
16 stars 36 forks source link

Allows dittybopper to be deployed in user-specified namespaces #47

Closed krishvoor closed 1 year ago

krishvoor commented 2 years ago

Description

Allow dittydopper to be deployed in user-specific namespaces.

Signed-off-by: Krishna Harsha Voora krvoora@redhat.com

krishvoor commented 2 years ago

@smalleni @mukrishn ptal

mukrishn commented 2 years ago

I would rather default it to dittybopper ns and make it overrid'able if they need to be on user-specified ns, but is there any benefit on making this on a different ns ?

krishvoor commented 2 years ago

Yes, the default is always dittybopper ns and the existing logic is also inline to be overridden w/ a user-specified ns, however, the deployment fails as below given.

This PR just appreciates the inline logic and allows it to be deployed in non-dittybopper ns as well

Using k8s command: oc
Using namespace: harsha
Using default grafana password: admin

Getting environment vars...
Prometheus URL is: https://prometheus-k8s-openshift-monitoring.apps.xxxxxx/
Prometheus bearer token collected.

Creating namespace...
namespace/harsha created

Deploying Grafana...
Error from server (NotFound): error when creating "STDIN": namespaces "dittybopper" not found
Error from server (NotFound): error when creating "STDIN": namespaces "dittybopper" not found
Error from server (NotFound): error when creating "STDIN": namespaces "dittybopper" not found
Error from server (NotFound): error when creating "STDIN": namespaces "dittybopper" not found
Error from server (NotFound): error when creating "STDIN": namespaces "dittybopper" not found
[root@krvoora dittybopper]#
mukrishn commented 2 years ago

Ahh got it, it was there already but templates have hard coded it. Also make sure you apply this on the user specified project.

krishvoor commented 1 year ago

Also make sure you apply this on the user specified project.

Thanks for the pointer, I pushed those changes as of now, can you ptal?

krishvoor commented 1 year ago

PFA the logs user_ns.log default_ns.log