Closed krishvoor closed 1 year ago
The lint failure is not relevant to PR, reproduced this locally
[krvoora@krvoora performance-dashboards]$ for t in templates/*.jsonnet; do echo "Testing template ${t}"; ./bin/jsonnetfmt --test $t; echo 'Results:' ${?}; done
Testing template templates/api-performance-overview.jsonnet
Results: 0
Testing template templates/cilium-k8s-perf.jsonnet
Results: 0
Testing template templates/etcd-on-cluster-dashboard.jsonnet
Results: 0
Testing template templates/hypershift-performance.jsonnet
Results: 0
Testing template templates/k8s-perf.jsonnet
Results: 0
Testing template templates/kube-burner.jsonnet
Results: 0
Testing template templates/ocp-performance.jsonnet
Results: 0
Testing template templates/ovn-dashboard.jsonnet
Results: 0
Testing template templates/pgbench-dashboard.jsonnet
Results: 0
Testing template templates/uperf-perf.jsonnet
Results: 0
Testing template templates/vegeta-wrapper.jsonnet
Results: 0
Testing template templates/ycsb.jsonnet
Results: 0
[krvoora@krvoora performance-dashboards]$
Here's how the panel will look like, the panel plots against 2 pods and service for a given duration
Ptal: @jtaleric @chaitanyaenr @mukrishn
@krishvoor seems to be some linting issues? I tried to see what the CI is complaining about, but I couldn't pinpoint it... Maybe run locally to determine the lint issue.
@jtaleric yes, could not pin-point CI-lint issue, however, ran the lint locally and see no issues, here are my observations, https://github.com/cloud-bulldozer/performance-dashboards/pull/52#issuecomment-1221963276
Any way to tell the CI to re-run the failed job?
@jtaleric @mukrishn @chaitanyaenr please let me know if you need anything on this.
This PR adds a new metric, to understand duration for OVN to apply network configurations
Signed-off-by: Krishna Harsha Voora krvoora@redhat.com