search

cloud-bulldozer / performance-dashboards

Performance dashboards from the Perf & Scale team
Apache License 2.0
17 stars 40 forks source link

Remove prometheus token duration #62

Closed afcollins closed 1 year ago

afcollins commented 1 year ago

Description

If a cluster is up for longer than 6h, the token needs to be refreshed.

I see the expiration as unnecessary maintenance overhead.

paigerube14 commented 1 year ago

/lgtm

qiliRedHat commented 1 year ago

@afcollins I just found this PR after I opened https://github.com/cloud-bulldozer/performance-dashboards/pull/67. The current default token expire time is 1 hour, it is short for a long running cluster's monitoring in reliability test. Is there a security concern that you removed the --duration?

afcollins commented 1 year ago

No, my intention was to have it not expire. I thought the default was no expiration. If the default is 1h then the duration should be increased.